why would my vendor module's Android.bp be skipped after conversion from Android.mk ?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

why would my vendor module's Android.bp be skipped after conversion from Android.mk ?

Robert Dugal
I am working on converting an Android.mk into an Android.bp for a vendor module that we are porting to 8.1
We had this working on 7.0 and 8.0 but ran into problems when trying to update to 8.1

The only reason I am doing this conversion is because some other system module switched from Android.mk to Android.bp and now it cannot find my vendor module when I build.
From what I can tell it appears my vendor module needs to now use Android.bp in order for the other system module to correctly resolve the dependency for my module.
Someone please correct me if that is not true.

When I build it appears that for some reason my Android.bp file is not being processed at all. 
If I put garbage in my Android.bp file no errors are generated when I try "make modules".
If I look in out/soong/.bootstrap/build.ninja.d I don't see my Android.bp being processed but I see other vendor/qcom/ modules being processed.
If I try to build from my vendor module directory I get the error "ninja: error: unknown target 'MODULES-IN-vendor-..... "
The only way I can seem to get this working is to switch the system module back to using Android.mk but then there are things in Android.bp (vendor_available, vndk, etc.) that I don't know how to replicate with Android.mk

I am confused as to why my Android.bp is not being used.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to
[hidden email]
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: why would my vendor module's Android.bp be skipped after conversion from Android.mk ?

Wesolowski, Krzysztof
Android.bp uses glob patterns instead of recursive search as Android.mk.

So go to top level Android.bp and start digging into subdirs - you will find where the inclusion chain breaks.

BR, K.

Get Outlook for Android


From: [hidden email] <[hidden email]> on behalf of Robert Dugal <[hidden email]>
Sent: Friday, January 19, 2018 12:47:44 PM
To: Android Building
Subject: [android-building] why would my vendor module's Android.bp be skipped after conversion from Android.mk ?
 
I am working on converting an Android.mk into an Android.bp for a vendor module that we are porting to 8.1
We had this working on 7.0 and 8.0 but ran into problems when trying to update to 8.1

The only reason I am doing this conversion is because some other system module switched from Android.mk to Android.bp and now it cannot find my vendor module when I build.
From what I can tell it appears my vendor module needs to now use Android.bp in order for the other system module to correctly resolve the dependency for my module.
Someone please correct me if that is not true.

When I build it appears that for some reason my Android.bp file is not being processed at all. 
If I put garbage in my Android.bp file no errors are generated when I try "make modules".
If I look in out/soong/.bootstrap/build.ninja.d I don't see my Android.bp being processed but I see other vendor/qcom/ modules being processed.
If I try to build from my vendor module directory I get the error "ninja: error: unknown target 'MODULES-IN-vendor-..... "
The only way I can seem to get this working is to switch the system module back to using Android.mk but then there are things in Android.bp (vendor_available, vndk, etc.) that I don't know how to replicate with Android.mk

I am confused as to why my Android.bp is not being used.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to
android-building+[hidden email]
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to
[hidden email]
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: why would my vendor module's Android.bp be skipped after conversion from Android.mk ?

Dan Willemsen-2
Yeah, subdirs is likely the issue here. In master, we do a full search of all Android.bp files (ignoring subdirs), which would avoid this problem.

- Dan

On Fri, Jan 19, 2018 at 12:43 PM, Wesolowski, Krzysztof <[hidden email]> wrote:
Android.bp uses glob patterns instead of recursive search as Android.mk.

So go to top level Android.bp and start digging into subdirs - you will find where the inclusion chain breaks.

BR, K.

Get Outlook for Android


From: [hidden email] <[hidden email]> on behalf of Robert Dugal <[hidden email]>
Sent: Friday, January 19, 2018 12:47:44 PM
To: Android Building
Subject: [android-building] why would my vendor module's Android.bp be skipped after conversion from Android.mk ?
 
I am working on converting an Android.mk into an Android.bp for a vendor module that we are porting to 8.1
We had this working on 7.0 and 8.0 but ran into problems when trying to update to 8.1

The only reason I am doing this conversion is because some other system module switched from Android.mk to Android.bp and now it cannot find my vendor module when I build.
From what I can tell it appears my vendor module needs to now use Android.bp in order for the other system module to correctly resolve the dependency for my module.
Someone please correct me if that is not true.

When I build it appears that for some reason my Android.bp file is not being processed at all. 
If I put garbage in my Android.bp file no errors are generated when I try "make modules".
If I look in out/soong/.bootstrap/build.ninja.d I don't see my Android.bp being processed but I see other vendor/qcom/ modules being processed.
If I try to build from my vendor module directory I get the error "ninja: error: unknown target 'MODULES-IN-vendor-..... "
The only way I can seem to get this working is to switch the system module back to using Android.mk but then there are things in Android.bp (vendor_available, vndk, etc.) that I don't know how to replicate with Android.mk

I am confused as to why my Android.bp is not being used.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to
[hidden email]
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to
[hidden email]
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to
[hidden email]
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: why would my vendor module's Android.bp be skipped after conversion from Android.mk ?

er1m
Sorry to resurrect an old thread, but I had the same issue today, and the reason for the failure was that I had replaced one of my repos by a symlink, and Soong ignores symlinks when searching for Android.bp files.

Le vendredi 19 janvier 2018 à 22:15:01 UTC+1, Dan Willemsen a écrit :
Yeah, subdirs is likely the issue here. In master, we do a full search of all Android.bp files (ignoring subdirs), which would avoid this problem.

- Dan

On Fri, Jan 19, 2018 at 12:43 PM, Wesolowski, Krzysztof <[hidden email]> wrote:
Android.bp uses glob patterns instead of recursive search as Android.mk.

So go to top level Android.bp and start digging into subdirs - you will find where the inclusion chain breaks.

BR, K.

Get Outlook for Android


From: [hidden email] <[hidden email]> on behalf of Robert Dugal <[hidden email]>

Sent: Friday, January 19, 2018 12:47:44 PM
To: Android Building
Subject: [android-building] why would my vendor module's Android.bp be skipped after conversion from Android.mk ?
I am working on converting an Android.mk into an Android.bp for a vendor module that we are porting to 8.1
We had this working on 7.0 and 8.0 but ran into problems when trying to update to 8.1

The only reason I am doing this conversion is because some other system module switched from Android.mk to Android.bp and now it cannot find my vendor module when I build.
From what I can tell it appears my vendor module needs to now use Android.bp in order for the other system module to correctly resolve the dependency for my module.
Someone please correct me if that is not true.

When I build it appears that for some reason my Android.bp file is not being processed at all. 
If I put garbage in my Android.bp file no errors are generated when I try "make modules".
If I look in out/soong/.bootstrap/build.ninja.d I don't see my Android.bp being processed but I see other vendor/qcom/ modules being processed.
If I try to build from my vendor module directory I get the error "ninja: error: unknown target 'MODULES-IN-vendor-..... "
The only way I can seem to get this working is to switch the system module back to using Android.mk but then there are things in Android.bp (vendor_available, vndk, etc.) that I don't know how to replicate with Android.mk

I am confused as to why my Android.bp is not being used.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]

To unsubscribe from this group, send email to

For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].

For more options, visit https://groups.google.com/d/optout.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]

To unsubscribe from this group, send email to

For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].

For more options, visit https://groups.google.com/d/optout.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to
[hidden email]
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/f862a9a8-a273-4dd9-be53-998ffc5591dan%40googlegroups.com.